On Wed, Oct 2, 2024 at 11:39 AM Ilya Leoshkevich <i...@linux.ibm.com> wrote:
>
> On Wed, 2024-10-02 at 09:05 -0500, Noah Goldstein wrote:
> > On Wed, Oct 2, 2024 at 3:08 AM Ilya Leoshkevich <i...@linux.ibm.com>
> > wrote:
> > >
> > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote:
> > > > The new option '-qemu-children' makes it so that on `execve` the
> > > > child
> > > > process will be launch by the same `qemu` executable that is
> > > > currently
> > > > running along with its current commandline arguments.
> > > >
> > > > The motivation for the change is to make it so that plugins
> > > > running
> > > > through `qemu` can continue to run on children.  Why not just
> > > > `binfmt`?: Plugins can be desirable regardless of
> > > > system/architecture
> > > > emulation, and can sometimes be useful for elf files that can run
> > > > natively. Enabling `binfmt` for all natively runnable elf files
> > > > may
> > > > not be desirable.
> > >
> > > Another reason to have this is that one may not have root
> > > permissions
> > > to configure binfmt-misc.
> > >
> > +1
> >
> > > There was a similar patch posted to the mailing list some years
> > > back,
> > > which I used to cherry-pick when I needed this. I'm not sure what
> > > happened to that discussion though.
> >
> > Yes(ish):
> > https://patchwork.ozlabs.org/project/qemu-devel/patch/1455515507-26877-1-git-send-email-petros...@resin.io/
>
> Thanks for finding this! Don't we need the shebang handling here as
> well?
>
I don't think so. In this case we aren't making it so execve can point to
some arbitrary impl, just that we propagate the current running qemu
env.

> Laurent, do you per chance know why was it not accepted back
> then?Unfortunately I cannot find any discussion associated with v3 or
> v4
> [1]. There were some concerns regarding v1 [2], but from what I can see
> they all were addressed.
>
> [1]
> https://patchew.org/QEMU/20200730160106.16613-1-rj.bcje...@gmail.com/
> [2]
> https://patchwork.kernel.org/project/qemu-devel/patch/1453091602-21843-1-git-send-email-petros...@gmail.com/

Reply via email to