On Thu, Oct 10, 2024, 12:20 Marc-André Lureau <[email protected]> wrote:
> Hi Roman > > On Thu, Oct 10, 2024 at 1:28 PM Roman Penyaev <[email protected]> wrote: > >> `mux_cnt` struct member never goes negative or decrements, >> so mux chardev can be !busy only when there are no >> frontends attached. This patch fixes the always-true >> check. >> >> Fixes: a4afa548fc6d ("char: move front end handlers in CharBackend") >> Signed-off-by: Roman Penyaev <[email protected]> >> Cc: "Marc-André Lureau" <[email protected]> >> Cc: [email protected] > > > Reviewed-by: Marc-André Lureau <[email protected]> > > That would be worth some new tests for chardev removal. It seems to be > lacking. And mux probably need extra fixing. I can take a look if you don't. > I assume no one removes mux device, so no one observes the error. Please, go ahead, I'm not sure I do fully understand what exactly should be fixed. -- Roman
