On Wed, Oct 30, 2024 at 08:58:21AM +0800, liequan che wrote: > Introduce the SM3 cryptographic hash algorithm (GB/T 32905-2016). > > SM3 (GB/T 32905-2016) is a cryptographic standard issued by the > Organization of State Commercial Cryptography Administration (OSCCA) > as an authorized cryptographic algorithm for use within China. > > Detect the SM3 cryptographic hash algorithm and enable the feature silently > if it is available. > > Signed-off-by: cheliequan <[email protected]> > --- > crypto/hash-gcrypt.c | 3 +++ > crypto/hash-nettle.c | 14 ++++++++++++ > crypto/hash.c | 3 +++ > crypto/hmac-gcrypt.c | 3 +++ > crypto/hmac-nettle.c | 11 ++++++++++ > crypto/pbkdf-gcrypt.c | 6 ++++++ > crypto/pbkdf-nettle.c | 13 ++++++++++++ > include/crypto/hash.h | 1 + > meson.build | 39 ++++++++++++++++++++++++++++++++++ > qapi/crypto.json | 3 ++- > tests/unit/test-crypto-hash.c | 16 ++++++++++++++ > tests/unit/test-crypto-hmac.c | 8 +++++++ > tests/unit/test-crypto-pbkdf.c | 16 ++++++++++++++ > 13 files changed, 135 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> In testing this, I hit a pre-existing bug in our hash availability detection which causes tests on fail on RHEL/Fedora. Not the fault of your patch, it merely exposes the problem: https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg05589.html I'm queuing your patch, but I have to wait for review of the above two fixes before merging. BTW, your email here was sent as mixed plain/HTML and your mail client has applied line-wrapping to the plain text. This prevented git from applying the patch. It was easy enough for me to fixup the line wrapping, so no need to resend this, but in future please ensure to send patches as only plain text, no HTML, and without line wrapping. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
