On Mon, Nov 25, 2024 at 10:34 AM Daniel P. Berrangé <berra...@redhat.com> wrote: > IMHO we need to have confidence not only in the current state of the code, > but also that we're not going to accidentally regresss it in the future. > This is what the gcc_struct attribute gives us confidence in.
Yes, as you say below the "solution" to that could be simply to avoid bitfields. They are problematic anyway for big-endian machines, see the commit that Thomas pointed out. Unfortunately it's a human-enforced solution, but then it is already human-enforced for endianness issues. > As an alternative is it practical for us to eliminate all bitfields > from our structs ? It is (at least for guest-visible structs), but it is a lot of work and I don't think it's reasonable for it to block clang enablement on Windows. Of course it is possible for future contributions. Pierrick, would you like to contribute a patch to docs/devel/style.rst as well? Paolo
