Em Fri, 22 Nov 2024 17:19:44 +0100
Igor Mammedov <imamm...@redhat.com> escreveu:
> > +
> > + if (!physical_address) {
> > + error_report("can not find Generic Error Status Block for source
> > id %d",
> > + source_id);
>
> isn't it a copy paste error from somewhere, perhaps it's mixed up with
> something else?
> Granted, the check was there before patches but error message seems bogus.
>
> Also 'physical_address' is a faulty page here, and 0 is as valid as any other
> value.
> I'd say we should drop the check, and if from ARM/KVM pov 0 addr shouldn't
> exist
> then it should be up to caller to filter it out and not call
> acpi_ghes_record_errors()
> in the 1st place.
I'll add a patch just before this one removing the physical_address check,
and remove it from the moved function on this patch.
I'll submit a v5 once you review patches 13-15 from this series.
Regards,
Mauro
