On Sun, 1 Dec 2024 at 15:17, Richard Henderson
<[email protected]> wrote:
>
> Signed-off-by: Richard Henderson <[email protected]>
> ---
> target/arm/tcg/translate-a64.c | 287 +++++++++++++--------------------
> target/arm/tcg/a64.decode | 8 +
> 2 files changed, 116 insertions(+), 179 deletions(-)
> +/* FCMP, FCMPE */
> +static bool trans_FCMP(DisasContext *s, arg_FCMP *a)
> +{
> + int check;
> +
> + if (a->z && a->rm != 0) {
> + return false;
We did not check this case before, and the pseudocode in the
Arm ARM doesn't check it either (there's a comment for the rm
field that says "ignored when opc<0> == '1'").
> + }
> + check = fp_access_check_scalar_hsd(s, a->esz);
> + if (check <= 0) {
> + return check == 0;
> + }
> +
> + handle_fp_compare(s, a->esz, a->rn, a->rm, a->z, a->e);
> + return true;
> +}
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
