On 12/12/24 18:22, Paolo Bonzini wrote:
For CR, the ugly-ish "0.into()" idiom is already hidden within the Default trait. Do not repeat it.For FR, standardize on reset() being equivalent to "*self = Self::default()" and let reset_fifo toggle only the bits that are related to FIFOs. This commit also reproduces C commit 02b1f7f6192 ("hw/char/pl011: Split RX/TX path of pl011_reset_fifo()", 2024-09-13). Signed-off-by: Paolo Bonzini <[email protected]> --- rust/hw/char/pl011/src/device.rs | 23 ++++++++++++++++------- rust/hw/char/pl011/src/lib.rs | 13 +++++-------- 2 files changed, 21 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
