On Wed, Dec 18, 2024 at 04:20:56PM +0000, Alex Bennée wrote:
> Now we have virtio-gpu Vulkan support lets add a test for it.
> Currently this is using images build by buildroot:
>
> https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html
>
> Signed-off-by: Alex Bennée <[email protected]>
>
> ---
> v2
> - use decorator for has_cmd(zstd)
> - move set_machine/require_accelerator to top of test
> - un-handled->unhandled
> - drop extra - from --snapshot
> - drop unneeded virtualization=on
> - only show 1s of each scene
> - fix long lines
> ---
> tests/functional/test_aarch64_virt.py | 84 ++++++++++++++++++++++++++-
> 1 file changed, 81 insertions(+), 3 deletions(-)
>
> + @skipUnless(*has_cmd('zstd'))
> + def test_aarch64_virt_with_gpu(self):
> + # This tests boots with a buildroot test image that contains
> + # vkmark and other GPU exercising tools. We run a headless
> + # weston that nevertheless still exercises the virtio-gpu
> + # backend.
> +
> + self.set_machine('virt')
> + self.require_accelerator("tcg")
> +
> + image_path_zst = self.ASSET_VIRT_GPU_ROOTFS.fetch()
> + kernel_path = self.ASSET_VIRT_GPU_KERNEL.fetch()
> +
> + image_path = self.workdir + "/rootfs.ext4"
Pending PULL has removed all direct access to self.workdir,
use 'self.scratch_file("rootfs.ext4") instead, except that
shouldn't be needed either....
> +
> + run_cmd(['zstd', "-f", "-d", image_path_zst,
> + "-o", image_path])
...the pending PULL has added common helpers for uncompression,
but only covers gz + lzma so far. Can you create a 'zstd_uncompress'
in uncompress.py and wire it up in the same way. That would let
this code turn into
image_path = self.uncompress(self.ASSERT_VIRT_GPU_ROOTFS)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
