On 23/12/2024 18:31, Cédric Le Goater wrote:
> On 12/23/24 18:55, Joao Martins wrote:
>> On 18/12/2024 13:40, Avihai Horon wrote:
>>> Hello,
>>>
>>> This follows up on Peter's series [1] to simplify migration status API
>>> to a single migration_is_running() function.
>>>
>>> Peter's series tried to drop migration_is_device() and
>>> migration_is_active(), however VFIO used them to check if dirty page
>>> tracking has been started in order to avoid errors in log sync, so they
>>> couldn't simply be dropped without some preliminary cleanups.
>>>
>>> This series handles these preliminary cleanups and eventually drops
>>> migration_is_device() and unexports migration_is_active().
>>>
>>> The series has been migration tested with the following:
>>> - VFIO device dirty tracking.
>>> - Legacy VFIO iommu dirty tracking.
>>> - vIOMMU + Legacy VFIO iommu dirty tracking (migration with vIOMMU is
>>> currently blocked, so I used a patched QEMU to allow it).
>>>
>>> I also tested calc-dirty-rate as now VFIO dirty pages should be included
>>> in its report, and indeed they are.
>>>
>>> I didn't test it with iommu DPT as I don't have access to such HW.
>>> It would be great if someone with the proper HW could test it.
>>>
>> FWIW tested iommufd DPT (migration and calc-dirty-rate) on said compatible
>> hardware (Milan hardware). Things look to be working as expected.
>
> Could we have a Tested-by tag then ?
>
Yes:
Tested-by: Joao Martins <[email protected]>
>> I deferred
>> vIOMMU IOMMUFD DPT testing to my own follow-up once I am back from vacation.
>>
>> Thanks for fixing calc-dirty-rate along the way your cleanup!
>
>
> Thanks,
>
> C.
>
>
