Re: [Qemu-devel] [PATCH 1/4] block: use Error mechanism instead of -errno for block_job_create()

[Paolo Bonzini]

Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto:
> +    stream_start(bs, base_bs, base, block_stream_cb, bs, errp);
> +    if (error_is_set(errp)) {
> +        return;
>      }

This needs to be

    Error *local_err = NULL;
    stream_start(bs, base_bs, base, block_stream_cb, bs, &local_err);
    if (local_err) {
        error_propagate(errp, local_err);
        return;
    }

Otherwise looks good.

Paolo