>>>>> "Peter" == Peter Maydell <peter.mayd...@linaro.org> writes:
Peter> On 23 April 2012 00:31, Peter Chubb <peter.ch...@nicta.com.au>
Peter> wrote:
Peter> Rather than having the *_clk_freq saved and loaded in the
Peter> vmstate, I think it would be nicer to have a post-load-hook
Peter> that called update_clocks().
OK.
>> /* mfn is 10-bit signed twos-complement */
>> + mfn -= (mfn & 0x200);
Peter> What is this calculation supposed to do? It doesn't convert a
Peter> 10-bit signed twos-complement number into an int32_t, unless
Peter> I'm confused... Also, it's a rather opaque way to write "mfn &=
Peter> 0x200;".
I'll use a different way to calculate. Maybe:
mfn <<= (32-10);
mfn >>= (32-10);
Peter C
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
