On 14/1/25 11:48, [email protected] wrote:
From: Marc-André Lureau <[email protected]>
../migration/savevm.c: In function
‘qemu_savevm_state_complete_precopy_non_iterable’:
../migration/savevm.c:1560:20: error: ‘ret’ may be used uninitialized
[-Werror=maybe-uninitialized]
1560 | return ret;
| ^~~
Cc: Peter Xu <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index c929da1ca5..6e56d4cf1d 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1557,7 +1557,7 @@ int
qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f,
migrate_set_error(ms, local_err);
error_report_err(local_err);
qemu_file_set_error(f, -EFAULT);
- return ret;
+ return -1;
Preferably reducing 'ret' scope:
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
}
}
if (!in_postcopy) {
