On Sat, 11 Jan 2025 at 18:37, Bernhard Beschow <[email protected]> wrote: > > Commit ce5dd27534b0 "hw/sd: Remove omap2_mmc device" removed the last user of > sd_set_cb(). Rework this functionality into GPIOs. > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > Signed-off-by: Bernhard Beschow <[email protected]>
What is this for? We have a non-legacy API for "the SD controller needs to know when the SD card is inserted or the readonly status changes", which is that the controller implements the SDBasClass set_inserted and set_readonly methods. (See the pl011 for an example.) I would prefer it if we used that consistently, rather than having two mechanisms, one using GPIO lines and one using class methods. I think we should delete the sd_set_cb() API and handling code entirely. thanks -- PMM
