Re: [PATCH 5/9] hw/char/bcm2835_aux: Really use RX FIFO depth

[Philippe Mathieu-Daudé]

On 20/2/25 09:21, Luc Michel wrote:

On 22:08 Wed 19 Feb     , Philippe Mathieu-Daudé wrote:

While we model a 8-elements RX FIFO since the PL011 model was
introduced in commit 97398d900ca ("bcm2835_aux: add emulation
of BCM2835 AUX block") we only read 1 char at a time!

I'm not sure I get why in this patch and the subsequent ones you keep
mentioning the PL011 model while you modify other UARTs. I guess you
mean "the BCM2835 AUX model" here?

Oops too much copy/pasting...

In any case:

Reviewed-by: Luc Michel <luc.mic...@amd.com>

Thanks!

Have the IOCanReadHandler handler return how many elements are
available, and use that in the IOReadHandler handler.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  hw/char/bcm2835_aux.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)