This commit renames the macros to accurately reflect the direction of DMA operations.
EDU_DMA_TO_PCI now represents reading memory content into the EDU buffer, while EDU_DMA_FROM_PCI represents writing EDU buffer content to memory. The previous naming was misleading, as the definitions were reversed. Signed-off-by: Jason Chien <jason.ch...@sifive.com> --- hw/misc/edu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index 504178b4a2..1353c67dc2 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -63,8 +63,8 @@ struct EduState { #define EDU_DMA_RUN 0x1 #define EDU_DMA_DIR(cmd) (((cmd) & 0x2) >> 1) -# define EDU_DMA_FROM_PCI 0 -# define EDU_DMA_TO_PCI 1 +# define EDU_DMA_TO_PCI 0 +# define EDU_DMA_FROM_PCI 1 #define EDU_DMA_IRQ 0x4 struct dma_state { dma_addr_t src; @@ -146,7 +146,7 @@ static void edu_dma_timer(void *opaque) return; } - if (EDU_DMA_DIR(edu->dma.cmd) == EDU_DMA_FROM_PCI) { + if (EDU_DMA_DIR(edu->dma.cmd) == EDU_DMA_TO_PCI) { uint64_t dst = edu->dma.dst; edu_check_range(dst, edu->dma.cnt, DMA_START, DMA_SIZE); dst -= DMA_START; -- 2.43.2