On Mon, Mar 3, 2025 at 11:24 AM 汪鹏程 <[email protected]> wrote: > > What about plugins under `tests/tcg/plugins/`?
It feels a bit odd to install something from the tests directory. If certain plugins in tests/tcg/plugins are of general use (not just for testing) then it might be reasonable to move them to contrib/plugins. > From: "Christoph Müllner"<[email protected]> > Date: Mon, Mar 3, 2025, 18:09 > Subject: [External] [PATCH] contrib/plugins: Install plugins to moddir > To: <[email protected]>, "Alex Bennée"<[email protected]>, > "Alexandre Iooss"<[email protected]>, "Mahmoud > Mandour"<[email protected]>, "Pierrick > Bouvier"<[email protected]> > Cc: "Wang Pengcheng"<[email protected]>, "Christoph > Müllner"<[email protected]> > Currently the built plugins can only be found in the build directory. > This patch lists them as installable objects, which will be copied > into qemu_moddir with `make install`. > > Signed-off-by: Christoph Müllner <[email protected]> > --- > contrib/plugins/meson.build | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/contrib/plugins/meson.build b/contrib/plugins/meson.build > index 82c97ca0f5..c25a1871b7 100644 > --- a/contrib/plugins/meson.build > +++ b/contrib/plugins/meson.build > @@ -14,11 +14,15 @@ if get_option('plugins') > include_directories: '../../include/qemu', > link_depends: [win32_qemu_plugin_api_lib], > link_args: win32_qemu_plugin_api_link_flags, > - dependencies: glib) > + dependencies: glib, > + install: true, > + install_dir: qemu_moddir) > else > t += shared_module(i, files(i + '.c'), > include_directories: '../../include/qemu', > - dependencies: glib) > + dependencies: glib, > + install: true, > + install_dir: qemu_moddir) > endif > endforeach > endif > -- > 2.47.1
