Philippe Mathieu-Daudé <[email protected]> writes: > On 3/3/25 18:25, Philippe Mathieu-Daudé wrote: >> When running checkpatch.pl on a commit adding a file without >> SPDX tag we get: >> Undefined subroutine &main::WARNING called at ./scripts/checkpatch.pl >> line 1694. >> The WARNING level is reported by the WARN() method. Fix the typo. >> Fixes: fa4d79c64da ("scripts: mandate that new files have >> SPDX-License-Identifier") >> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> >> --- >> Possible candidate to apply on /master as buildfix > > buildfix: because otherwise everybody running checkpatch and adding > new file without SPDX tag will have to debug checkpatch.pl. > >> --- >> scripts/checkpatch.pl | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index 83b59fb4436..6ae9d7febee 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -1691,8 +1691,8 @@ sub process { >> "'SPDX-License-Identifer'"); >> } else { >> # Other files MAY have SPDX license if appropriate >> - WARNING("Does new file '$expect_spdx_file' need " . >> - "'SPDX-License-Identifer'?"); >> + WARN("Does new file '$expect_spdx_file' need " . >> + "'SPDX-License-Identifer'?"); >> } >> } >> $expect_spdx = 1;
Reviewed-by: Markus Armbruster <[email protected]>
