Hi Cedric,

> Subject: Re: [PATCH v4 21/23] tests/functional/aspeed: Update test ASPEED
> SDK v09.05
> 
> May be add a little comment about the new ast2700-a0-default OpenBMC
> build in v09.05.
> 
Thanks for your suggestion and review.
I will add the following comments in commit log.
Jamin

In ASPEED SDK v09.05, the naming convention for pre-built images has been
updated. The pre-built image for AST2700 A0 has been renamed to
ast2700-a0-default, while ast2700-default is now used for AST2700 A1.

> On 3/3/25 10:54, Jamin Lin wrote:
> > Signed-off-by: Jamin Lin <[email protected]>
> 
> 
> Reviewed-by: Cédric Le Goater <[email protected]>
> 
> Thanks,
> 
> C.
> 
> 
> > ---
> >   tests/functional/test_aarch64_aspeed.py | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/tests/functional/test_aarch64_aspeed.py
> > b/tests/functional/test_aarch64_aspeed.py
> > index 07b0c7c1fd..8df6a97a28 100755
> > --- a/tests/functional/test_aarch64_aspeed.py
> > +++ b/tests/functional/test_aarch64_aspeed.py
> > @@ -27,9 +27,9 @@ def do_test_aarch64_aspeed_sdk_start(self, image):
> >           wait_for_console_pattern(self, '## Loading kernel from FIT
> Image')
> >           wait_for_console_pattern(self, 'Starting kernel ...')
> >
> > -    ASSET_SDK_V903_AST2700 = Asset(
> > -
> 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.03/ast
> 2700-default-obmc.tar.gz',
> > -
> '91225f50d255e2905ba8d8e0c80b71b9d157c3609770c7a740cd786370d85a77'
> )
> > +    ASSET_SDK_V905_AST2700 = Asset(
> > +
> 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast
> 2700-a0-default-obmc.tar.gz',
> > +
> > +
> 'cfbbd1cce72f2a3b73b9080c41eecdadebb7077fba4f7806d72ac99f3e84b74a')
> >
> >       def start_ast2700_test(self, name):
> >           num_cpu = 4
> > @@ -89,11 +89,11 @@ def start_ast2700_test(self, name):
> >           exec_command_and_wait_for_pattern(self,
> >               'cat
> > /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '18000')
> >
> > -    def test_aarch64_ast2700_evb_sdk_v09_03(self):
> > +    def test_aarch64_ast2700_evb_sdk_v09_05(self):
> >           self.set_machine('ast2700-evb')
> >
> > -        self.archive_extract(self.ASSET_SDK_V903_AST2700)
> > -        self.start_ast2700_test('ast2700-default')
> > +        self.archive_extract(self.ASSET_SDK_V905_AST2700)
> > +        self.start_ast2700_test('ast2700-a0-default')
> >
> >
> >   if __name__ == '__main__':

Reply via email to