On Fri, Feb 28, 2025 at 09:58:31AM +0100, Paolo Bonzini wrote: > Date: Fri, 28 Feb 2025 09:58:31 +0100 > From: Paolo Bonzini <[email protected]> > Subject: [PATCH] rust: qom: remove operations on &mut > X-Mailer: git-send-email 2.48.1 > > The dubious casts of mutable references to objects are not used > anymore: the wrappers for qdev_init_clock_in and for IRQ and MMIO > initialization can be called directly on the subclasses, without > casts, plus they take a shared reference so they can just use > "upcast()" instead of "upcast_mut()". Remove them. > > Signed-off-by: Paolo Bonzini <[email protected]> > --- > rust/qemu-api/src/prelude.rs | 1 - > rust/qemu-api/src/qom.rs | 83 ------------------------------------ > rust/qemu-api/tests/tests.rs | 34 +-------------- > 3 files changed, 2 insertions(+), 116 deletions(-)
Simplification is always a good thing, Reviewed-by: Zhao Liu <[email protected]>
