Hi,
On Tue, 4 Mar 2025 at 20:12, Peter Xu <[email protected]> wrote:
> IIUC Fabiano is not asking you to drop them, but split them. Split still
> "requires" them to be present, as long as before the enablement patch.
* Yes, same here; Even I am not suggesting to drop anything. Fabiano
mentioned the following about the changes being done:
1. _in preparation for_ the feature (multifd+postcopy enablement)
2. _as part of_ the feature (multifd+postcopy enablement)
3. Concerns about git bisect and backporting of patches, not
missing patches when backporting.
* I am thinking:
1. The _required_ changes are the _as part of_ the feature changes.
2. The refactoring of ram_save_target_page and moving of
MULTIFD_MAGIC/VERSION macros to multifd.h patch can be termed as _in
preparation for_ the feature. Of these
- Refactoring of 'ram_save_target_page' function patch is
already pulled upstream.
->
https://gitlab.com/qemu-project/qemu/-/commit/bc38dc2f5f350310724fd7d4f0a09f8c3a4811fa
- Similarly moving of MULTIFD_ macros patch can be pulled. It
has not changed for many revisions.
3. The _essential_ changes are further refinement of the feature
(multifd+postcopy enablement).
* IMO, we can split patches as:
- One patch for -> _required_ OR _as part of_ the feature changes
- One patch for -> MULTIFD_ macros as _in preparation for_ the
feature change
- One patch for -> _essential_ changes : flush and sync related
- Two patches for qtest cases related changes.
This division also seems helpful for git bisect and backporting
related concerns.
* Currently we are divided over what constitutes: _required_ OR _as
part of_ the feature changes.
- Hence the request for individual opinions towards that.
* If we want to merge _required_/_as part of_ the feature and
_essential_ changes together in one patch - I'm okay.
* If we want to split the _required_ / _as part of_ the feature patch
further into two, we need to define exactly how we do that division. -
[???]
* I have shared my thoughts above, I won't hold on to it unduly. We
need to find a way to move forward. I'm willing to go with either way
we decide.
Thank you.
---
- Prasad
