15.01.2025 00:21, Rodrigo Dias Correa wrote:
Instead of migrating the raw tick_offset, goldfish_rtc migrates a recalculated value based on QEMU_CLOCK_VIRTUAL. As QEMU_CLOCK_VIRTUAL stands still across a save-and-restore cycle, the guest RTC becomes out of sync with the host RTC when the VM is restored.As described in the bug description, it looks like this calculation was copied from pl031 RTC, which had its tick_offset migration fixed by Commit 032cfe6a79c8 ("pl031: Correctly migrate state when using -rtc clock=host"). Migrate the tick_offset directly, adding it as a version-dependent field to VMState. Keep the old behavior when migrating from previous versions. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2033
Is this a qemu-stable material? If yes, how far to older stable series it is worth to pick? (Currently active older stable series are 7.2 and 8.2). Please add Cc: qemu-stable@ for fixes which are supposed to be picked up for the stable series. Thanks, /mjt
