Hi Thomas, On Mon, Mar 17, 2025 at 7:50 AM Thomas Huth <[email protected]> wrote:
> Hi! > > On 16/03/2025 21.21, Niek Linnenbank wrote: > > Hi Thomas, > > > > On Tue, Mar 11, 2025 at 5:08 PM Thomas Huth <[email protected] > > <mailto:[email protected]>> wrote: > > > > The tests have been converted to the functional framework, so > > we should not talk about Avocado here anymore. > ... > > diff --git a/docs/system/arm/orangepi.rst > b/docs/system/arm/orangepi.rst > > index db87e81fec4..8b9448ca7b0 100644 > > --- a/docs/system/arm/orangepi.rst > > +++ b/docs/system/arm/orangepi.rst > > @@ -257,9 +257,9 @@ Orange Pi PC integration tests > > > > Perhaps for consistency, we can also rename to 'functional tests' here. > > Agreed, we don't use the term "integration tests" for this anymore. > > > > > The Orange Pi PC machine has several integration tests included. > > > > And same on this line. > > > > To run the whole set of tests, build QEMU from source and simply > > -provide the following command: > > +provide the following command from the build directory: > > > > .. code-block:: bash > > > > - $ AVOCADO_ALLOW_LARGE_STORAGE=yes avocado --show=app,console run \ > > - -t machine:orangepi-pc tests/avocado/boot_linux_console.py > > + $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 \ > > + meson test --suite thorough func-arm-arm_orangepi > > > > I've tried to run on my Ubuntu 24.04.1 LTS based system using this exact > > same command, but got this error: > > > > $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 meson test --suite thorough func-arm- > > arm_orangepi > > > > ERROR: Build data file '/home/user/qemu/build/meson-private/build.dat' > > references functions or classes that don't exist. This probably means > that > > it was generated with an old version of meson. Consider reconfiguring > the > > directory with "meson setup --reconfigure". > > > > The meson version I have installed via apt-get is 1.3.2-1ubuntu1. Only > when > > running using the 'meson' command from the pyvenv, it runs OK: > > > > $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 ./pyvenv/bin/meson test --suite > thorough > > func-arm-arm_orangepi > > Oh, you're right! Thanks for catching it! > > I guess I still had a "export PYTHONPATH=$HOME/qemu/python" in my > environment, so I did not notice. Would you like to send a patch, or want > me > to do it? > Yes please feel free to go ahead with the patch. With the above minor remarks resolved, it looks fine to me: Reviewed-by: Niek Linnenbank <[email protected]> Regards, Niek > > Thomas > > -- Niek Linnenbank
