On 25/03/25 22:50, Cédric Le Goater wrote:
On 3/25/25 12:23, Aditya Gupta wrote:
Implement Pnv11Chip, currently without chiptod, xive and phb.
Chiptod, XIVE, PHB are implemented in later patches.
Since Power11 core is same as Power10, the implementation of Pnv11Chip
is a duplicate of corresponding Pnv10Chip.
Cc: Cédric Le Goater <[email protected]>
Cc: Frédéric Barrat <[email protected]>
Cc: Mahesh J Salgaonkar <[email protected]>
Cc: Madhavan Srinivasan <[email protected]>
Cc: Nicholas Piggin <[email protected]>
Signed-off-by: Aditya Gupta <[email protected]>
Looks correct, one comment below.
Anyhow,
Reviewed-by: Cédric Le Goater <[email protected]>
<...snip...>
+ object_initialize_child(obj, "adu", &chip11->adu, TYPE_PNV_ADU);
+ object_initialize_child(obj, "psi", &chip11->psi, TYPE_PNV11_PSI);
+ object_initialize_child(obj, "lpc", &chip11->lpc, TYPE_PNV11_LPC);
+ object_initialize_child(obj, "occ", &chip11->occ, TYPE_PNV11_OCC);
+ object_initialize_child(obj, "sbe", &chip11->sbe, TYPE_PNV11_SBE);
+ object_initialize_child(obj, "homer", &chip11->homer,
TYPE_PNV11_HOMER);
As said earlier, if the models of the HW units above are the same
on P10 an P11, you could simply use the P10 types. That's fine.
Just add a little comment.
Sure, made that change in my tree. And thanks for the tag Cédric !
- Aditya Gupta
Thanks,
C.
