zoudongjie <[email protected]> writes:
> On Wed, Mar 26, 2025 at 10:53:20 +0100, Markus wrote:
>> zoudongjie via <[email protected]> writes:
>>
>> > From: Zhu Yangyang <[email protected]>
>> >
>> > Calling qmp_block_set_io_throttle() will be blocked for a long time
>> > when a network disk is configured and the network failure is just about
>> > to occur.
What other commands could similarly block?
>> > Therefore, we add a timeout parameter for qmp_block_set_io_throttle to
>> > control
>> > its execution duration.
>>
>> What's the QMP reply when a block_set_io_throttle command times out?
>
> The reply is:
> {"id":"libvirt-484","error":{"class":"GenericError","desc":"Blk io limits
> disable timeout"}}
I find the error message confusing. Suggest "command timed out".
>> >
>> > The default value of timeout is 0, that is infinite wait, consistent with
>> > previous behavior.
>> >
>> > Signed-off-by: Zhu Yangyang <[email protected]>
[...]
