Re: [PATCH for-10.1 v2 36/37] vfio: Rename VFIODevice related services

[Cédric Le Goater]

On 3/27/25 10:50, John Levon wrote:
On Wed, Mar 26, 2025 at 08:51:21AM +0100, Cédric Le Goater wrote:
  /* Returns 0 on success, or a negative errno. */
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 
4fdb74e33c427595a9b0a4d28b2b5a70df951e4e..9000702aed960ccb69ca67ec052f1ebe11ee1919
 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -117,7 +117,7 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice 
*vapdev,
      fd = event_notifier_get_fd(notifier);
      qemu_set_fd_handler(fd, fd_read, NULL, vapdev);
  
-    if (!vfio_set_irq_signaling(vdev, irq, 0, VFIO_IRQ_SET_ACTION_TRIGGER, fd,
+    if (!vfio_device_irq_set_signaling(vdev, irq, 0, 
VFIO_IRQ_SET_ACTION_TRIGGER, fd,
                                  errp)) {

Nit, indentation is still off on this and several other places.

Yes. I fixed a few. Not all of them, as I prioritize code readability.

Thanks,

C.

 

regards
john