> Please resend the series with a cover letter
> (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch)
Ok, just resend this series with a cover letter and commit message.
(patches unchanged)
> > +#include <gst/gst.h>
> > +
> > +static void libavcodec_destroy_encoder_context(VncState *vs)
>
> it's not libavcodec.
I will fix that in v2.
> > +#ifdef CONFIG_GSTREAMER
> > + case VNC_ENCODING_H264:
> > + if (vnc_h264_encoder_init(vs) == 0) {
> > + vnc_set_feature(vs, VNC_FEATURE_H264);
>
> Before advertising support for the codec, it should actually check if
> the encoder is present.
ok.
> It would also be useful to have an extra VNC
> option like H264=on/off/auto.
I thought it would be better to do that at the client?
