On Wed, 9 May 2012 11:24:00 +0200
Jim Meyering <j...@meyering.net> wrote:
> From: Jim Meyering <meyer...@redhat.com>
>
> NUL-termination of the .ifr_name field is not required, but is fine
> (and preferable to using strncpy and leaving the reader to wonder),
> since the first thing the linux kernel does is to clear the last byte.
> Besides, using pstrcpy here makes this setting of ifr_name consistent
> with the other code (e.g., net/tap-linux.c) that does the same thing.
>
> Signed-off-by: Jim Meyering <meyer...@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitul...@redhat.com>
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index d58730a..7112984 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -786,7 +786,7 @@ GuestNetworkInterfaceList
> *qmp_guest_network_get_interfaces(Error **errp)
> }
>
> memset(&ifr, 0, sizeof(ifr));
> - strncpy(ifr.ifr_name, info->value->name, IF_NAMESIZE);
> + pstrcpy(ifr.ifr_name, IF_NAMESIZE, info->value->name);
> if (ioctl(sock, SIOCGIFHWADDR, &ifr) == -1) {
> snprintf(err_msg, sizeof(err_msg),
> "failed to get MAC addres of %s: %s",
