On 17/4/25 20:28, Pierrick Bouvier wrote:
Maybe it would be preferable to focus on providing a minimal but
*complete* TargetInfo before upstreaming any of this, as it's really
blocking the rest of the work for single binary.
I suppose I misunderstood you asking to post these reviewed patches as
separate of the TargetInfo series which need more work:
"I just feel the last 3 commits, and this one, are a bit disconnected
from the series."
https://lore.kernel.org/qemu-devel/0b4376ee-504b-4096-a590-8a509ec78...@linaro.org/
Minimal requirements to have a complete series would be:
- Rename QMP TargetInfo struct to use that name
- Be able to query target cpu type (what this series does)
- Be able to query machine cpu type
- Modify generic functions listing machines/cpus to take this into account
- Tag labeled boards/cpu in hw/arm to prove this is working (without
doing any other cleanup to those files and *not* make them common)
- No other additional target information for the v1, let's keep that for
later.
Note: target_cpu_type will not be TYPE_ARM_CPU, as it wrongly wraps
arm32 and aarch64 cpus, while it should correctly identify one or the
other. I suggested TYPE_TARGET_CPU_ARM, TYPE_TARGET_CPU_AARCH64, and
same for machines: TYPE_TARGET_MACHINE_ARM, TYPE_TARGET_MACHINE_AARCH64.
So we can reuse this naming convention with any other target we'll reuse
in the future.
Got it.
Pierrick
