John Snow <[email protected]> writes: > Since the previous commit, python/setup.cfg applies to scripts/qapi/ as > well. Configuration files in scripts/qapi/ override python/setup.cfg. > > scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match > python/setup.cfg exactly, and can go. > > The differences between scripts/qapi/mypy.ini and python/setup.cfg are > harmless: warn_unused_configs is actually the default for strict, so > this is vestigial.
Could you insert my "[PATCH] python: Drop redundant warn_unused_configs = True" right before this patch, and delete the explanation? > namespace_packages being set to True is a requirement > for the PEP420 nested package structure of QEMU but not for > scripts/qapi, but has no effect on type checking the QAPI > code. warn_unused_ignores is used in python/ to be able to target a wide > variety of mypy versions; some of which that have added new ignore > categories that are not present in older versions. > > Ultimately, scripts/qapi/mypy.ini can be removed without any real change > in behavior to how mypy enforces type safety there. > > The pylint config is being left in place because the settings differ > enough from the python/ directory settings that we need a chit-chat on > how to merge them O:-) > > Signed-off-by: John Snow <[email protected]>
