On Fri, Apr 18, 2025 at 05:17:02PM +0800, Zhao Liu wrote: > > configs/devices/i386-softmmu/default.mak | 1 + > > hw/i386/Kconfig | 5 +++ > > qapi/qom.json | 15 +++++++++ > > target/i386/kvm/meson.build | 2 ++ > > target/i386/kvm/tdx.c | 43 ++++++++++++++++++++++++ > > target/i386/kvm/tdx.h | 21 ++++++++++++ > > SEV.* and confidential-guest.* are all placed in target/i386/. > It's best if all of these can be in the same place. > > > 6 files changed, 87 insertions(+) > > create mode 100644 target/i386/kvm/tdx.c > > create mode 100644 target/i386/kvm/tdx.h > > ... > > > diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h > > new file mode 100644 > > index 000000000000..f3b725336161 > > --- /dev/null > > +++ b/target/i386/kvm/tdx.h > > @@ -0,0 +1,21 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > + > > +#ifndef QEMU_I386_TDX_H > > +#define QEMU_I386_TDX_H > > I386_TDX_H is enough... the QEMU prefix is rarely seen in the whole > project.
IMHO having a QEMU_ prefix here is "best practice", so don't remove it. That lots of other QEMU code doesn't follow best practice is unfortunate. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
