Hi Thomas,

On 23/4/25 11:40, Thomas Huth wrote:
On 23/04/2025 11.31, Bernhard Beschow wrote:


Am 10. April 2025 06:05:35 UTC schrieb Thomas Huth <[email protected]>:
On 09/04/2025 22.26, Bernhard Beschow wrote:
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic
operation of the USDHC.

Signed-off-by: Bernhard Beschow <[email protected]>

--
v2:
* Make test file executable (Thomas)
* Omit fetch() (Thomas)
* Omit "-accel tcg" (Thomas)
* Add "snapshot=on" to make potential future tests independent

Supersedes: [email protected]
---
   MAINTAINERS                                 |  1 +
   tests/functional/meson.build                |  1 +
   tests/functional/test_aarch64_imx8mp_evk.py | 66 ++++++++++++++++ +++++
   3 files changed, 68 insertions(+)
   create mode 100755 tests/functional/test_aarch64_imx8mp_evk.py

diff --git a/MAINTAINERS b/MAINTAINERS
index d54b5578f8..4ceffa89dc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -833,6 +833,7 @@ F: include/hw/arm/fsl-imx8mp.h
   F: include/hw/misc/imx8mp_*.h
   F: include/hw/pci-host/fsl_imx8m_phy.h
   F: docs/system/arm/imx8mp-evk.rst
+F: tests/functional/test_aarch64_imx8mp_evk.py
   F: tests/qtest/rs5c372-test.c
     MPS2 / MPS3
diff --git a/tests/functional/meson.build b/tests/functional/ meson.build
index 0f8be30fe2..aaaf3472f1 100644
--- a/tests/functional/meson.build
+++ b/tests/functional/meson.build
@@ -75,6 +75,7 @@ tests_aarch64_system_quick = [
     tests_aarch64_system_thorough = [
     'aarch64_aspeed',
+  'aarch64_imx8mp_evk',
     'aarch64_raspi3',
     'aarch64_raspi4',
     'aarch64_replay',
diff --git a/tests/functional/test_aarch64_imx8mp_evk.py b/tests/ functional/test_aarch64_imx8mp_evk.py
new file mode 100755
index 0000000000..62fee74044
--- /dev/null
+++ b/tests/functional/test_aarch64_imx8mp_evk.py
@@ -0,0 +1,66 @@
+#!/usr/bin/env python3
+#
+# Functional test that boots a Linux kernel and checks the console
+#
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+from qemu_test import LinuxKernelTest, Asset
+

In case you respin (due to other reasons), please add a second empty line before the "class" statement (that's the style that we use in the other tests, too).

Anyway:
Reviewed-by: Thomas Huth <[email protected]>

Ping (not for 10.0)

Peter, should this go through your arm tree, or shall I pick it up with other functional test patches for my next PR?

My preference would be like with previous Avocado tests: when a
(functional) test concerns mostly a dedicated subsystem, I'd rather see
the dedicated subsystem maintainers to take it, so they get familiar
with the test. Except if the maintainers are busy or unresponsive of
course.


Reply via email to