Am 03.04.2012 15:05, schrieb Paolo Bonzini: > Il 03/04/2012 14:28, Jan Kiszka ha scritto: >>>> if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { >>>> value = object_property_get_str(OBJECT(dev), legacy_name, >>>> &err); >> This is not a criticism on this patch, but I'd like to underline that >> the line above only works because legacy props also define print > ^^^^ > > You mean always, I guess. > >> But this statement above is still inconsistent. We should either >> assert(print && parse) or handle their non-existence properly. > > Yes, asserting that print/parse are always present in pairs (if at all) > would be good.
Paolo, has this issue been addressed somewhere? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg