On 05/14/2012 01:59 PM, Luiz Capitulino wrote: >>>> I'll declare it then. >>> >>> -Wredundant-decls doesn't like it: >>> >>> /home/lcapitulino/work/src/qmp-unstable/qga/commands-posix.c:38:15: >>> warning: redundant redeclaration of ‘environ’ [-Wredundant-decls] >>> /usr/include/unistd.h:546:15: note: previous declaration of ‘environ’ was >>> here >>> LINK qemu-ga
> > What's the worst case if we leave it as is? The build will brake if environ > ends up not being declared by some arch, right? In that case we could leave it > as is and fix it when it brakes :) Yep, which is precisely why I added my reviewed-by to v2. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
