On 5/29/2025 12:13 AM, Paolo Bonzini wrote:
On 5/26/25 05:47, Xiaoyao Li wrote:On 1/3/2025 4:48 PM, Xin Li (Intel) wrote:@@ -1133,6 +1134,25 @@ FeatureWordInfo feature_word_info[FEATURE_WORDS] = {}, .tcg_features = TCG_7_1_EAX_FEATURES, }, + [FEAT_7_1_ECX] = { + .type = CPUID_FEATURE_WORD, + .feat_names = { + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL,This looks silly, and the size of feat_names[] was changed from 32 to 64. Just explicitly assign the first 32 entries with NULL doesn't make any sense after the size change.64 is just for MSR features. This is a bit silly, I agree, but it is consistent with existing feature words and ultimately it becomes more compact after just 9 features. So I'm queuing Xin's patches as they are.
Paolo, thanks a lot!
Xin
