Re: [RFC PATCH RESEND 19/42] accel/split: Implement kick_vcpu_thread()

[Richard Henderson]

On 6/20/25 10:27, Philippe Mathieu-Daudé wrote:

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  accel/split/split-accel-ops.c | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/accel/split/split-accel-ops.c b/accel/split/split-accel-ops.c
index 746a6a2782d..63b6217f3fa 100644
--- a/accel/split/split-accel-ops.c
+++ b/accel/split/split-accel-ops.c
@@ -136,7 +136,13 @@ static void split_cpu_reset_hold(CPUState *cpu)

static void split_kick_vcpu_thread(CPUState *cpu)

  {
-    g_assert_not_reached();
+    SplitAccelState *sas = SPLIT_ACCEL(cpu->accel->accel);
+    AccelClass *ac = cpu->accel->use_hw ? ACCEL_GET_CLASS(sas->hw)
+                                        : ACCEL_GET_CLASS(sas->sw);

Move the ?: inside the ACCEL_GET_CLASS?

Anyway,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~

+
+    if (ac->ops->kick_vcpu_thread) {
+        ac->ops->kick_vcpu_thread(cpu);
+    }
  }

static bool split_cpu_thread_is_idle(CPUState *cpu)