On Wed, 2 Jul 2025 at 13:22, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> Implement FPProcessNaNs4 within f16_dotadd, rather than
should be "bfdotadd_ebf" ?
> simply letting NaNs propagate through the function.
>
> Cc: qemu-sta...@nongnu.org
> Fixes: 0e1850182a1 ("target/arm: Implement FPCR.EBF=1 semantics for
> bfdotadd()")
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> + /* C.f. FPProcessNaNs4 */
> + if (float32_is_any_nan(s1r) || float32_is_any_nan(s1c) ||
> + float32_is_any_nan(s2r) || float32_is_any_nan(s2c)) {
> + if (float32_is_signaling_nan(s2r, fpst)) {
> + t32 = s2r;
> + } else if (float32_is_signaling_nan(s2c, fpst)) {
> + t32 = s2c;
> + } else if (float32_is_signaling_nan(s2r, fpst)) {
> + t32 = s2r;
> + } else if (float32_is_signaling_nan(s2c, fpst)) {
> + t32 = s2c;
> + } else if (float32_is_any_nan(s2r)) {
> + t32 = s2r;
> + } else if (float32_is_any_nan(s2c)) {
> + t32 = s2c;
> + } else if (float32_is_any_nan(s2r)) {
> + t32 = s2r;
> + } else {
> + t32 = s2c;
> + }
Looks like a cut-and-paste error -- we check s2r and s2c
twice and never look at s1r and s1c.
-- PMM
