Am 22.05.2012 11:05, schrieb Jim Meyering: > Kevin Wolf wrote: >> A patch replacing tabs by spaces isn't really the kind of patches that >> we would want to avoid during freeze. It's easy enough to check with git >> diff -w that it doesn't change anything semantically. > > That makes sense, so I've posted two patches: > > 1) two patches: one replacing all leading TABs with equivalent spaces, > then the above patch > > Note however, that envlist.c must predate checkpatch.pl, since > that patch provokes numerous warnings about style issues:
Quite possible. Most files in qemu will still contain some violations. > (hmm... I've just noticed these first two, which seem to suggest > that even for comments I should remove the TABs. Is it worth > a V2 to fix those two lines? Or are they false positives, since > they're not really "code" indentation? ) We don't use tabs at all where possible. There shouldn't be much more exceptions than the Makefiles. Kevin
