On Thu, Jul 03, 2025 at 11:03:14PM -0400, Shaoqin Huang wrote: > Date: Thu, 3 Jul 2025 23:03:14 -0400 > From: Shaoqin Huang <shahu...@redhat.com> > Subject: [PATCH v9 1/2] ramfb: Add property to control if load the romfile > > Currently the ramfb device loads the vgabios-ramfb.bin unconditionally, > but only the x86 need the vgabios-ramfb.bin, this can cause that when > use the release package on arm64 it can't find the vgabios-ramfb.bin. > > Because only seabios will use the vgabios-ramfb.bin, load the rom logic > is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver > for ramfb, so they don't need to load the romfile. > > So add a new property use-legacy-x86-rom in both ramfb and vfio_pci > device, because the vfio display also use the ramfb_setup() to load > the vgabios-ramfb.bin file. > > After have this property, the machine type can set the compatibility to > not load the vgabios-ramfb.bin if the arch doesn't need it. > > For now the default value is true but it will be turned off by default > in subsequent patch when compats get properly handled. > > Reviewed-by: Eric Auger <eric.au...@redhat.com> > Signed-off-by: Shaoqin Huang <shahu...@redhat.com> > --- > hw/display/ramfb-standalone.c | 4 +++- > hw/display/ramfb-stubs.c | 2 +- > hw/display/ramfb.c | 6 ++++-- > hw/vfio/display.c | 4 ++-- > hw/vfio/pci.c | 1 + > hw/vfio/pci.h | 1 + > include/hw/display/ramfb.h | 2 +- > 7 files changed, 13 insertions(+), 7 deletions(-)
LGTM, Reviewed-by: Zhao Liu <zhao1....@intel.com>
