This spun out of understanding why we didn't get prior warning about our use of the deprecated 'asyncio.get_event_loop' feature. The answer is that python doesn't print any deprecation messages by default unless directly triggered by the __main__ module.
So here I wanted to get all python warning messages enabled for the iotests and functional tests, so we get a heads up of any other failures coming out way. In doing this it uncovered numerous places where we failed to cleanup with dangling file handles. I further uncovered lots of old compat code for py3.6 which we stopped needing a long while ago. I'm in two minds over whether the very last commit is suitable or not though. The iotests do strict comparison of stdout / stderr, so if we allow python warnings to appear that will break the iotests. At the same time though we do really want to see these warnings, especially when developers run the iotests manually, so just turning them on in CI is not very desirable. So wondering how to get the warnings for devs but not for users running from released tarballs? Also note that I ran 'check', 'check -qcow' and 'check -nbd' but this doesn't cover all possible iotest usage. So there might still be some resource leaks hiding in there which will cause failures for devs running tests with unusual config scenarios. Daniel P. Berrangé (13): python: avoid deprecation warning with get_event_loop python: drop 'is_closing' back compat helper python: drop 'wait_closed' back compat helper python: drop 'asyncio_run' back compat helper python: drop 'create_task' back compat helper iotests: drop compat for old version context manager functional: ensure log handlers are closed functional: ensure sockets and files are closed functional: always enable all python warnings python: ensure QEMUQtestProtocol closes its socket iotests/147: ensure temporary sockets are closed before exiting iotests/151: ensure subprocesses are cleaned up iotests/check: always enable all python warnings Richard W.M. Jones (1): python: Replace asyncio.get_event_loop for Python 3.14 python/qemu/machine/qtest.py | 2 + python/qemu/qmp/legacy.py | 10 ++- python/qemu/qmp/protocol.py | 13 ++-- python/qemu/qmp/qmp_tui.py | 10 +-- python/qemu/qmp/util.py | 97 +------------------------- python/tests/protocol.py | 9 ++- tests/functional/qemu_test/testcase.py | 6 ++ tests/functional/test_multiprocess.py | 3 + tests/functional/test_virtio_gpu.py | 2 + tests/qemu-iotests/147 | 1 + tests/qemu-iotests/151 | 5 ++ tests/qemu-iotests/check | 4 ++ tests/qemu-iotests/testenv.py | 7 +- tests/qemu-iotests/testrunner.py | 9 +-- 14 files changed, 51 insertions(+), 127 deletions(-) -- 2.49.0
