On Mon, Jul 14, 2025 at 01:03:06PM +0200, Paolo Bonzini wrote:
> From: Roy Hopkins <roy.hopk...@randomman.co.uk>
>
> The IGVM library allows Independent Guest Virtual Machine files to be
> parsed and processed. IGVM files are used to configure guest memory
> layout, initial processor state and other configuration pertaining to
> secure virtual machines.
>
> This adds the --enable-igvm configure option, enabled by default, which
> attempts to locate and link against the IGVM library via pkgconfig and
> sets CONFIG_IGVM if found.
>
> The library is added to the system_ss target in backends/meson.build
> where the IGVM parsing will be performed by the ConfidentialGuestSupport
> object.
> diff --git a/meson_options.txt b/meson_options.txt
> index a442be29958..1e429311a2d 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -117,6 +117,8 @@ option('tpm', type : 'feature', value : 'auto',
> description: 'TPM support')
> option('valgrind', type : 'feature', value: 'auto',
> description: 'valgrind debug support for coroutine stacks')
> +option('igvm', type: 'feature', value: 'auto',
> + description: 'Independent Guest Virtual Machine (IGVM) file support')
This description does not match...
>
> # Do not enable it by default even for Mingw32, because it doesn't
> # work on Wine.
> diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh
> index 73e0770f42b..78515404450 100644
> --- a/scripts/meson-buildoptions.sh
> +++ b/scripts/meson-buildoptions.sh
> @@ -130,6 +130,7 @@ meson_options_help() {
> printf "%s\n" ' hv-balloon hv-balloon driver (requires Glib 2.68+
> GTree API)'
> printf "%s\n" ' hvf HVF acceleration support'
> printf "%s\n" ' iconv Font glyph conversion support'
> + printf "%s\n" ' igvm IGVM file support'
... this description here, so when this file is re-generated by any
other pending patch touching meson options we get a spurious diff
for IGVM.
We really need to get something into 'make check' that runs the
generator and compares its output to 'meson-buildoptions.sh' as
we have hit this problem over & over again.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
