The UART clock frequency field of the SPCR table was added in revision 3. Currently, build_spcr() treats revision 3 tables the same as revision 2 and only includes this field in revision 4 tables.
Fix build_spcr() to include the clock frequency field in revision 3 tables. Per the specification, this is the only change between revisions 2 and 3. Signed-off-by: Vadim Chichikalyuk <chichikal...@gmail.com> --- hw/acpi/aml-build.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 1e685f982f..9855d5f053 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -2123,20 +2123,22 @@ void build_spcr(GArray *table_data, BIOSLinker *linker, build_append_int_noprefix(table_data, f->pci_flags, 4); /* PCI Segment */ build_append_int_noprefix(table_data, f->pci_segment, 1); - if (rev < 4) { + if (rev < 3) { /* Reserved */ build_append_int_noprefix(table_data, 0, 4); } else { /* UartClkFreq */ build_append_int_noprefix(table_data, f->uart_clk_freq, 4); - /* PreciseBaudrate */ - build_append_int_noprefix(table_data, f->precise_baudrate, 4); - /* NameSpaceStringLength */ - build_append_int_noprefix(table_data, f->namespace_string_length, 2); - /* NameSpaceStringOffset */ - build_append_int_noprefix(table_data, f->namespace_string_offset, 2); - /* NamespaceString[] */ - g_array_append_vals(table_data, name, f->namespace_string_length); + if (rev >= 4) { + /* PreciseBaudrate */ + build_append_int_noprefix(table_data, f->precise_baudrate, 4); + /* NameSpaceStringLength */ + build_append_int_noprefix(table_data, f->namespace_string_length, 2); + /* NameSpaceStringOffset */ + build_append_int_noprefix(table_data, f->namespace_string_offset, 2); + /* NamespaceString[] */ + g_array_append_vals(table_data, name, f->namespace_string_length); + } } acpi_table_end(linker, &table); } -- 2.39.5 (Apple Git-154)