On Fri, Jul 18, 2025 at 11:03:40PM +0200, Cédric Le Goater wrote: > On 7/18/25 21:43, Gerd Hoffmann wrote: > > From: Shaoqin Huang <shahu...@redhat.com> > > > > Move the TYPE_* to a new file hw/vfio/types.h because the > > TYPE_VFIO_PCI will be used in later patch, but directly include the > > hw/vfio/pci.h can cause some compilation error when cross build the > > windows version. > > > > The hw/vfio/types.h can be included to mitigate that problem. > > As said earlier, the string literal "vfio-pci" could be used instead > of the TYPE_VFIO_PCI define and avoid the extra vfio header file.
I think it makes sense to use TYPE_VFIO_PCI, for consistency and to avoid typos in the device name. take care, Gerd
