On Mon, Jul 21, 2025 at 04:59:12PM +0530, Arun Menon wrote: > The documentation of qemu_file_get_return_path() states that it can > return NULL on failure. However, a review of the current implementation > reveals that it is guaranteed that it will always succeed and will never > return NULL. > > As a result, the NULL checks post calling the function become redundant. > This commit updates the documentation for the function and removes all > NULL checks throughout the migration code. > > Signed-off-by: Arun Menon <arme...@redhat.com> > --- > migration/colo.c | 4 ---- > migration/migration.c | 12 ++---------- > migration/qemu-file.c | 1 - > migration/savevm.c | 4 ---- > 4 files changed, 2 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|