Am 23.05.2012 19:18, schrieb Paolo Bonzini: > Il 23/05/2012 19:06, Andreas Färber ha scritto: >> Am 02.05.2012 13:30, schrieb Paolo Bonzini: >>> Now that Object is a type, add an instance_init function and push >>> the "type" property from qdev to there. >>> >>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> >> The rebased version from qdev-props-4 breaks and hangs `make check`: >> >> GTESTER check-qtest-sparc >> qemu-system-sparc: Insufficient permission to perform this operation >> >> Paolo, can you please investigate? > > Please try this patch (untested; please add my signed-off-by if you end > up committing it).
Tested make check and PReP. I added some braces missing in the original code to please checkpatch.pl and applied both to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Paolo, please let me know if you're okay with my commit messages, then I can override the author to be you as well (same for preceding one). BTW note that I usually update subjects to start with a capital letter to visually separate the lowercase topic from the actual summary. ;) > There is also a "type" property in arm_l2x0.c, but it seems unused. Peter, can we drop that property? I'd insert such a patch before then. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
