On 2012-05-24 10:10, Igor Mammedov wrote: > On 05/23/2012 11:26 PM, Peter Maydell wrote: >> On 23 May 2012 22:09, Igor Mammedov<imamm...@redhat.com> wrote: >>> For cpu-hotplug it was suggested to use device_add/del >>> interface for it. To do so in a generalized way hot-plugged cpu >>> should follow general QOM object creation sequence, i.e. >>> - create new cpu instance >>> - set properties >>> - realize instance >>> without creating precedent of special case for cpus in device_add/del >>> if possible. So goal is to have a self-sufficient cpu object that >>> doesn't require external hooks to create/initialize it. It looks >>> possible do so for target-i386 at least. >> >> I think your self-sufficient CPU object should probably be a >> container QOM object which contains the CPU core itself and >> the APIC device. Then the container object's initialisation >> can map the APIC device. > > For x86 it would be artificial thing without a real hardware to > model after, that would needlessly complicate code and interface. > I'd rather avoid this.
No, letting the CPU map the APIC is really the proper way to deal with it, specifically once we will support remapping. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux