On 5/8/25 01:03, Richard Henderson wrote:
On 8/4/25 23:33, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (11):
hw/sd/sdcard: Do not ignore errors in sd_cmd_to_sendingdata()
hw/sd/sdcard: Factor sd_response_size() out
hw/sd/sdbus: Provide buffer size to sdbus_do_command()
hw/sd/sdcard: Fill SPI response bits in card code
hw/sd/sdcard: Implement SPI R2 return value
hw/sd/sdcard: Use complete SEND_OP_COND implementation in SPI mode
hw/sd/sdcard: Allow using SWITCH_FUNCTION in more SPI states
hw/sd/sdcard: Factor spi_cmd_SEND_CxD() out
hw/sd/sdcard: Disable checking STBY mode in SPI SEND_CSD/CID
hw/sd/sdcard: RemoveSDState::mode field
tests/functional: Test SD cards in SPI mode (using sifive_u machine)
I've reached the limit of what I can review simply by looking at the
code, rather than absorb the specs. The rest looks plausible, and
doesn't twig the Spidey sense that something icky is going on, so
Acked-by: Richard Henderson <[email protected]>
Thanks a lot!