> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Thursday, May 24, 2012 5:12 PM > On 05/24/2012 05:10 AM, Paolo Bonzini wrote: > > Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto: > >> Prevent disk data loss when closing qemu console window > >> under Windows 7. > >> > >> Signed-off-by: Pavel Dovgalyuk<pavel.dovga...@gmail.com> > >> --- > >> os-win32.c | 6 +++++- > >> 1 files changed, 5 insertions(+), 1 deletions(-) > >> > >> diff --git a/os-win32.c b/os-win32.c > >> index ad76370..66c39b8 100644 > >> --- a/os-win32.c > >> +++ b/os-win32.c > >> @@ -57,7 +57,11 @@ int setenv(const char *name, const char *value, int > >> overwrite) > >> > >> static BOOL WINAPI qemu_ctrl_handler(DWORD type) > >> { > >> - exit(STATUS_CONTROL_C_EXIT); > >> + qemu_system_shutdown_request(); > >> + /* Windows 7 kills application when the function returns. > >> + Sleep here to give QEMU a try for closing */ > >> + Sleep(10000); > >> + > >> return TRUE; > >> } > > > > Reviewed-by: Paolo Bonzini<pbonz...@redhat.com> > > > > Anthony, can you queue it for 1.1? > > Is that a 10 second sleep? I really think this needs a much, much better > commit > message. Random sleeps like this are poison and need to be carefully > justified.
I've updated the comment in the code, please check the new version of the patch. Pavel Dovgaluk