Re: [PATCH v7 08/11] hw/loongarch: Implement avec set irq

[Bibo Mao]

On 2025/9/10 下午5:11, Song Gao wrote:

Implement avec set irq and update CSR_MSGIS.

Signed-off-by: Song Gao <gaos...@loongson.cn>
---
  hw/intc/loongarch_avec.c | 32 ++++++++++++++++++++++++++++++--
  1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/hw/intc/loongarch_avec.c b/hw/intc/loongarch_avec.c
index 1f9f376898..0c90579de2 100644
--- a/hw/intc/loongarch_avec.c
+++ b/hw/intc/loongarch_avec.c
@@ -16,6 +16,14 @@
  #include "migration/vmstate.h"
  #include "trace.h"
  #include "hw/qdev-properties.h"
+#include "target/loongarch/cpu.h"
+#include "qemu/error-report.h"
+#include "system/hw_accel.h"
+
+/* msg addr field */
+FIELD(MSG_ADDR, IRQ_NUM, 4, 8)
+FIELD(MSG_ADDR, CPU_NUM, 12, 8)
+FIELD(MSG_ADDR, FIX, 28, 12)

static uint64_t loongarch_avec_mem_read(void *opaque,

                                          hwaddr addr, unsigned size)
@@ -23,13 +31,33 @@ static uint64_t loongarch_avec_mem_read(void *opaque,
      return 0;
  }

+static void do_set_vcpu_avec_irq(CPUState *cs, run_on_cpu_data data)

+{
+    int irq = data.host_int;
+    CPULoongArchState *env;
+
+    env = &LOONGARCH_CPU(cs)->env;
+    cpu_synchronize_state(cs);
+    set_bit(irq, env->CSR_MSGIS);
+}
+
  static void loongarch_avec_mem_write(void *opaque, hwaddr addr,
                                       uint64_t val, unsigned size)
  {
-    return;
+    int irq_num, cpu_num = 0;
+    LoongArchAVECState *s = LOONGARCH_AVEC(opaque);
+    uint64_t msg_addr = addr + VIRT_AVEC_BASE;
+    CPUState *cs;
+
+    cpu_num = FIELD_EX64(msg_addr, MSG_ADDR, CPU_NUM);
+    cs = cpu_by_arch_id(cpu_num);
+    irq_num = FIELD_EX64(msg_addr, MSG_ADDR, IRQ_NUM);
+
+    async_run_on_cpu(cs, do_set_vcpu_avec_irq,
+                         RUN_ON_CPU_HOST_INT(irq_num));
+    qemu_set_irq(s->cpu[cpu_num].parent_irq, 1);
  }

-

  static const MemoryRegionOps loongarch_avec_ops = {
      .read = loongarch_avec_mem_read,
      .write = loongarch_avec_mem_write,

Reviewed-by: Bibo Mao <maob...@loongson.cn>