On Wed, May 30, 2012 at 08:14:03AM +0300, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 10:13:07AM +0800, Anthony Liguori wrote: > > On 05/20/2012 05:57 PM, Amos Kong wrote: > > >Start VM with 8 multiple-function block devs, hot-removing > > >those block devs by 'device_del ...' would cause qemu abort. > > > > > >| (qemu) device_del virti0-0-0 > > >| (qemu) ** > > >|ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) > > > > > >It's a regression introduced by commit 57c9fafe > > > > > >The whole PCI slot should be removed once. Currently only one func > > >is cleaned in pci_unplug_device(), if you try to remove a single > > >func by monitor cmd. > > > > > >free_qdev() are called for all functions in slot, > > >but unparent_delete() is only called for one > > >function. > > > > > >--- > > >aliguori has a better resolution, better to do it in 1.2 > > > > > >v2: fix warning: too many arguments for format > > >v3: move object_unparent() to acpi_piix_eject_slot() > > > > > >Signed-off-by: Amos Kong<kongjian...@gmail.com> > > > > Applied. Thanks. > > > > Regards, > > > > Anthony Liguori
BTW git log shows for this commit: Signed-off-by: XXXX Any idea why?