Re: [PATCH v8 07/11] hw/loongarch: Implement dintc realize and unrealize

[Bibo Mao]

On 2025/9/16 下午8:21, Song Gao wrote:

Implement th DINTC realize and unrealize.

Signed-off-by: Song Gao <gaos...@loongson.cn>
---
  hw/intc/loongarch_dintc.c | 23 ++++++++++++++++++++++-
  target/loongarch/cpu.h    |  3 ++-
  2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/hw/intc/loongarch_dintc.c b/hw/intc/loongarch_dintc.c
index 7173a6aa29..598c666ec6 100644
--- a/hw/intc/loongarch_dintc.c
+++ b/hw/intc/loongarch_dintc.c
@@ -38,7 +38,12 @@ static const MemoryRegionOps loongarch_dintc_ops = {

static void loongarch_dintc_realize(DeviceState *dev, Error **errp)

  {
+    LoongArchDINTCState *s = LOONGARCH_DINTC(dev);
      LoongArchDINTCClass *lac = LOONGARCH_DINTC_GET_CLASS(dev);
+    MachineState *machine = MACHINE(qdev_get_machine());
+    MachineClass *mc = MACHINE_GET_CLASS(machine);
+    const CPUArchIdList  *id_list;
+    int i;

Error *local_err = NULL;

      lac->parent_realize(dev, &local_err);
@@ -47,12 +52,28 @@ static void loongarch_dintc_realize(DeviceState *dev, Error 
**errp)
          return;
      }

+ assert(mc->possible_cpu_arch_ids);

+    id_list = mc->possible_cpu_arch_ids(machine);
+    s->num_cpu = id_list->len;
+    s->cpu = g_new(DINTCCore, s->num_cpu);
+    if (s->cpu == NULL) {
+        error_setg(errp, "Memory allocation for DINTCCore fail");
+        return;
+    }
+
+    for (i = 0; i < s->num_cpu; i++) {
+        s->cpu[i].arch_id = id_list->cpus[i].arch_id;
+        s->cpu[i].cpu = CPU(id_list->cpus[i].cpu);
+        qdev_init_gpio_out(dev, &s->cpu[i].parent_irq, 1);
+    }
+
      return;
  }

static void loongarch_dintc_unrealize(DeviceState *dev)

  {
-    return;
+    LoongArchDINTCState *s = LOONGARCH_DINTC(dev);
+    g_free(s->cpu);
  }

static void loongarch_dintc_init(Object *obj)

diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h
index 807a710810..237c93cdd6 100644
--- a/target/loongarch/cpu.h
+++ b/target/loongarch/cpu.h
@@ -217,9 +217,10 @@ FIELD(CSR_CRMD, WE, 9, 1)
  extern const char * const regnames[32];
  extern const char * const fregnames[32];

-#define N_IRQS 13

+#define N_IRQS      15
  #define IRQ_TIMER   11
  #define IRQ_IPI     12
+#define INT_DMSI    14

#define LOONGARCH_STLB 2048 /* 2048 STLB */

  #define LOONGARCH_MTLB         64   /* 64 MTLB */

Reviewed-by: Bibo Mao <maob...@loongson.cn>